Jerusalem, even though it's a hot spot, I think everywhere is nowadays. At least there is the history, scenery of places in the Bible and the aura of times past there.
It's not exactly as exciting as I had imagined. It's definitely a tourist trap...
Israel, including Jerusalem, is safe. It's a police state. There are police and soldiers (IDF) everywhere. There is no violent crime whatsoever.
The Taxi drivers are the biggest crooks...the shops in Old City are the next biggest. The money exchange places are actually the most honest places to go. (You can't buy anything with dollars...has to be shekels)
And I will say that knowing the history and geography BEFORE you go helps. That way you know what you are looking at and not relying on your tour guide. My wife and I didn't use one. We did just fine with busses and taxis. (Avoid King David hotel... just saying)
The place is fine. The people tend to be annoying. I prefer peace and relaxing more. Like South America...they know how to have fun and relax. It's just humid and warm there...and everything is trying to get you sick.